Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no temporary files are written when balancing .hic files with --in-memory #280

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Oct 6, 2024

No description provided.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (7282aba) to head (fcde580).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/hictk/balance/common.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   79.01%   79.04%   +0.02%     
==========================================
  Files         171      171              
  Lines       16325    16327       +2     
  Branches     2250     2251       +1     
==========================================
+ Hits        12900    12905       +5     
+ Misses       2456     2455       -1     
+ Partials      969      967       -2     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/280/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 69.54% <66.66%> (+0.11%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/280/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 76.43% <ø> (+<0.01%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 5e298f6 into main Oct 7, 2024
120 of 123 checks passed
@robomics robomics deleted the fix/balance-tmpdir-hic branch October 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant